Skip to content

fix: Correct logic for github_actions_organization_workflow_permissions#3222

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-actions-org-workflow-permissions
Mar 18, 2026
Merged

fix: Correct logic for github_actions_organization_workflow_permissions#3222
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-actions-org-workflow-permissions

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

Resolves #ISSUE_NUMBER


Before the change?

  • The github_actions_organization_workflow_permissions resource can't set can_approve_pull_request_reviews to false

After the change?

  • The github_actions_organization_workflow_permissions resource works correctly

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.12.0 Release milestone Feb 24, 2026
@stevehipwell stevehipwell self-assigned this Feb 24, 2026
@stevehipwell stevehipwell added the Type: Bug Something isn't working as documented label Feb 24, 2026
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell
Copy link
Copy Markdown
Collaborator Author

CC @deiga this is why we can't use d.GetOk() for booleans; ok is false for zero values.

@stevehipwell
Copy link
Copy Markdown
Collaborator Author

@robert-crandall please could you review this PR?

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the fix-actions-org-workflow-permissions branch from c9717b5 to 3d23f5a Compare March 16, 2026 22:37
@stevehipwell stevehipwell merged commit 080c081 into integrations:main Mar 18, 2026
7 checks passed
@stevehipwell stevehipwell deleted the fix-actions-org-workflow-permissions branch March 18, 2026 12:03
JiayangZhou pushed a commit to JiayangZhou/terraform-provider-github that referenced this pull request Apr 16, 2026
…ns (integrations#3222)

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants